EnxDev commented on PR #41392:
URL: https://github.com/apache/superset/pull/41392#issuecomment-4834294379
## EnxDev's Review Agent โ apache/superset#41392 ยท HEAD bae3a1c
comment โ The one-line change fixes click-to-focus, but it likely removes
the only way to copy a cell value in the Community build. Worth confirming
before merge.
### ๐ด Functional
- **`plugin-chart-ag-grid-table/src/AgGridTable/index.tsx:528`** ยท _Medium_
โ Setting `enableCellTextSelection={false}` disables native browser text
selection inside cells. Only Community modules are registered
(`AllCommunityModule` + `ClientSideRowModelModule`, line 113); the
clipboard/`copy`/`copyWithHeaders`/`paste` items (lines 601โ603) are AG Grid
Enterprise and inert here. So before this PR users could highlight cell text
and Ctrl+C to copy a value โ the only copy path in this build โ and after it
they can't copy at all (focused cell + no clipboard module = Ctrl+C does
nothing). Net: the table loses copy-a-value entirely to gain a focus outline.
Confirm the product intent is to drop text-copy; if not, this trade needs a
different fix (e.g. a custom copy handler, or scoping the selection change to
only what #106389 needs). **regression test:** render the grid, focus a cell,
assert text-copy still works (or that the intended cell-selection state is set)
โ a Jest/RTL
test asserting the `enableCellTextSelection` prop value would at least pin
the decision.
### ๐ก Should-fix
- No regression test ships with the behavioral change. "Existing render
tests pass" doesn't guard this โ a test should assert the new
click-selects-cell behavior (or the prop value) so the choice isn't silently
flipped back later.
### ๐ต Nits
- PR is still marked draft (`review:draft`) โ flip to ready when you want a
formal maintainer review.
<!-- enxdev-review-agent:bae3a1c -->
_Reviewed by EnxDev's Review Agent โ @EnxDev ยท HEAD bae3a1c._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
