villebro commented on code in PR #41007:
URL: https://github.com/apache/superset/pull/41007#discussion_r3493271952
##########
superset/views/base.py:
##########
@@ -423,6 +423,7 @@ def get_theme_bootstrap_data() -> dict[str, Any]:
"theme": {
"default": default_theme,
"dark": dark_theme,
+ "defaultMode": app.config.get("THEME_DEFAULT_MODE", "system"),
Review Comment:
Nit: we have a convention to always use dictionary indexing as opposed to
safe lookups for config flags that are defined in `config.py`.
```suggestion
"defaultMode": app.config["THEME_DEFAULT_MODE"],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
