durgaprasadml opened a new pull request, #41536:
URL: https://github.com/apache/superset/pull/41536
SUMMARY
This PR fixes a regression introduced in Superset 6.1.0 where dashboard
chart descriptions no longer remain expanded despite the chart being present in
expanded_slices.
The root cause was that SliceHeaderControls uses the isDescriptionExpanded
prop to determine whether to render “Show chart description” or “Hide chart
description”, but SliceHeader was only passing isExpanded.
As a result, the menu state became desynchronized from the actual
description state, causing the dropdown to always display “Show chart
description” and making the toggle behavior appear broken.
BEFORE
* Dashboard loads with:
{
"expanded_slices": {
"123": true
}
}
* Description may already be expanded.
* Dropdown incorrectly displays:
Show chart description
* Clicking the option collapses the description, making the feature appear
non-functional.
AFTER
* Dashboard descriptions correctly reflect the persisted expansion state.
* Dropdown labels remain synchronized with the actual description visibility.
* Toggle behavior works as expected.
TESTING
Added regression coverage to verify:
* Expanded descriptions display the correct menu state.
* Toggle behavior updates labels correctly.
* Existing dashboard functionality remains unchanged.
Fixes #40373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
