bito-code-review[bot] commented on PR #41530:
URL: https://github.com/apache/superset/pull/41530#issuecomment-4835284499
<!-- Bito Reply -->
The suggestion to add explicit type annotations is correct and improves code
readability and maintainability. You can resolve this by adding the following
type hints to the variables in `superset/cli/thumbnails.py`:
```python
items: list[tuple[int, str]] = [(model.id, str(model)) for model in
query.all()]
count: int = len(items)
if asynchronous:
func: Callable = compute_func.delay
action: str = "Triggering"
else:
func: Callable = compute_func
action: str = "Processing"
```
There are no other comments on this PR. Would you like me to check for any
other potential type-hinting improvements in this file?
**superset/cli/thumbnails.py**
```
items: list[tuple[int, str]] = [(model.id, str(model)) for model in
query.all()]
count: int = len(items)
if asynchronous:
func: Callable = compute_func.delay
action: str = "Triggering"
else:
func: Callable = compute_func
action: str = "Processing"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
