codeant-ai-for-open-source[bot] commented on code in PR #39922:
URL: https://github.com/apache/superset/pull/39922#discussion_r3493569665
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -1665,24 +1707,28 @@ def reject_sql_expression_on_dimensions(self) ->
"XYChartConfig":
@model_validator(mode="after")
def validate_unique_column_labels(self) -> "XYChartConfig":
"""Ensure all column labels are unique across x, y, and group_by."""
- labels_seen: dict[str, str] = {}
+ # Key is (saved_metric, label) so a saved metric and a regular column
+ # with the same input name are not flagged as duplicates — saved
metrics
+ # resolve to their actual casing from the dataset during normalization.
+ labels_seen: dict[tuple[bool, str], str] = {}
duplicates: list[str] = []
# Add x-axis label if present (x may be None, resolved later).
# The dimension validator rejects sql_expression on x, so name is set.
if self.x is not None:
x_label = self.x.label or self.x.name or ""
- labels_seen[x_label] = "x"
+ labels_seen[(self.x.saved_metric, x_label)] = "x"
# Check Y-axis labels
for i, col in enumerate(self.y):
label = _metric_display_label(col)
- if label in labels_seen:
+ key = (col.saved_metric, label)
+ if key in labels_seen:
duplicates.append(
- f"y[{i}]: '{label}' (conflicts with {labels_seen[label]})"
+ f"y[{i}]: '{label}' (conflicts with {labels_seen[key]})"
)
else:
- labels_seen[label] = f"y[{i}]"
+ labels_seen[key] = f"y[{i}]"
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag `(saved_metric, label)` keys in duplicate-label validators for
chart schema validators; saved metrics and ad-hoc metrics may normalize to
different canonical names, and duplicate-label enforcement should be deferred
to the query layer when needed.
**Applied to:**
- `superset/mcp_service/chart/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
