sadpandajoe commented on code in PR #41532:
URL: https://github.com/apache/superset/pull/41532#discussion_r3493625496
##########
superset-frontend/src/dashboard/components/Header/index.tsx:
##########
@@ -468,7 +468,9 @@ const Header = (): JSX.Element => {
if (positionJSONLength >= limit) {
boundActionCreators.addDangerToast(
t(
- 'Your dashboard is too large. Please reduce its size before saving
it.',
+ 'Your dashboard is too large to save: the layout is %s bytes but the
limit is %s bytes. Reduce the dashboard size (for example, split it into
multiple dashboards) or raise the SUPERSET_DASHBOARD_POSITION_DATA_LIMIT config
setting.',
Review Comment:
Layout can include non-ASCII markdown/tab text, while the backend persists
positions through Python JSON serialization, so this can diverge from actual
stored byte size. Either compute a true serialized byte length or phrase the
toast/docs as “serialized layout length” instead of bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
