aminghadersohi commented on code in PR #40961: URL: https://github.com/apache/superset/pull/40961#discussion_r3493779561
########## tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py: ########## @@ -0,0 +1,387 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Unit tests for the MCP get_dashboard_datasets tool.""" + +from unittest.mock import Mock, patch + +import pytest +from fastmcp import Client + +from superset.mcp_service.app import mcp +from superset.mcp_service.utils.sanitization import ( + LLM_CONTEXT_CLOSE_DELIMITER, + LLM_CONTEXT_OPEN_DELIMITER, +) +from superset.utils import json + + +def _wrapped(value: str) -> str: + return f"{LLM_CONTEXT_OPEN_DELIMITER}\n{value}\n{LLM_CONTEXT_CLOSE_DELIMITER}" + + +def _build_column_mock( + name: str, + *, + verbose_name: str | None = None, + type_: str | None = "VARCHAR", + is_dttm: bool = False, +) -> Mock: + column = Mock() + column.column_name = name + column.verbose_name = verbose_name + column.type = type_ + column.is_dttm = is_dttm + return column + + +def _build_metric_mock( + name: str, + *, + verbose_name: str | None = None, + expression: str | None = None, +) -> Mock: + metric = Mock() + metric.metric_name = name + metric.verbose_name = verbose_name + metric.expression = expression + return metric + + +def _build_database_mock( + *, database_id: int = 7, name: str = "examples", backend: str = "postgresql" +) -> Mock: + database = Mock() + database.id = database_id + database.database_name = name + database.backend = backend + return database + + +def _build_datasource_mock( + *, + dataset_id: int, + uuid: str | None = None, + table_name: str = "my_table", + schema: str | None = "public", + database: Mock | None = None, + columns: list[Mock] | None = None, + metrics: list[Mock] | None = None, +) -> Mock: + datasource = Mock() + datasource.id = dataset_id + datasource.uuid = uuid + datasource.table_name = table_name + datasource.schema = schema + datasource.database = database + datasource.columns = columns or [] + datasource.metrics = metrics or [] + return datasource + + +def _build_slice_mock(datasource: Mock) -> Mock: + slc = Mock() + slc.datasource_id = datasource.id + slc.datasource = datasource + return slc + + +def _build_dashboard_mock( + *, + dashboard_id: int = 1, + title: str = "Test Dashboard", + uuid: str | None = "dashboard-uuid-1", + slices: list[Mock] | None = None, +) -> Mock: + dashboard = Mock() + dashboard.id = dashboard_id + dashboard.dashboard_title = title + dashboard.uuid = uuid + dashboard.slices = slices or [] + return dashboard + + [email protected] +def mcp_server(): + return mcp + + [email protected](autouse=True) +def mock_auth(): + with patch("superset.mcp_service.auth.get_user_from_request") as mock_get_user: + mock_user = Mock() + mock_user.id = 1 + mock_user.username = "admin" + mock_get_user.return_value = mock_user + yield mock_get_user + + [email protected](autouse=True) +def mock_dataset_access(): + with patch( + "superset.mcp_service.auth.has_dataset_access", return_value=True + ) as mock_access: + yield mock_access Review Comment: Keeping test helpers and fixtures unannotated to match the existing convention in sibling mcp_service test files (`test_get_dashboard_layout.py`, `test_get_dashboard_info.py`), where pytest fixtures and helper functions carry no type annotations. `mypy` passes on these files. Same rationale as the resolved thread on this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
