sadpandajoe commented on PR #41491: URL: https://github.com/apache/superset/pull/41491#issuecomment-4837224226
@rusackas It seems like we are missing regression coverage for the two failure paths you added in `embedded/index.tsx` and `menu.tsx`. A targeted Jest test should force `setupPlugins()`/`setupCodeOverrides()` to reject, resend `guestToken`, and assert plugin setup is retried and render/user bootstrap can proceed. Another small test should cover menu rendering after `initPreamble()` rejects and logging when import/render fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
