Aitema-gmbh commented on PR #39234: URL: https://github.com/apache/superset/pull/39234#issuecomment-4841816834
Hi @rusackas — circling back on your question. To answer it directly: this isn't a11y-specific scoping — it's general "correct behavior" that happens to also satisfy WCAG 1.4.3. Link colors route through the theme tokens, and the `ensureLinkContrast()` helper only nudges the *default* Ant Design link token until it reaches the 4.5:1 ratio. The moment an operator supplies a custom brand/link color, the helper steps aside completely. So default deployments are compliant out of the box, while full theme customization is preserved — a sensible default for everyone, with the contrast guarantee as the motivation. The automated reviewers (Bito / CodeAnt / Copilot) are all at **0 actionable suggestions** and patch coverage is ~95%. The branch has sat for a few weeks, so I'm happy to rebase onto current master for a fresh green CI run if that's useful — just say the word. Otherwise I think this is ready for a final look / approval. Thanks for shepherding these a11y PRs! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
