Aitema-gmbh commented on PR #39233: URL: https://github.com/apache/superset/pull/39233#issuecomment-4842094717
@rusackas rebased onto current master and resolved the conflicts. One decision worth flagging: I dropped our changes to `AlertStatusIcon`. Master already conveys alert status through distinct icon shapes (check / close / warning / calendar), tooltip labels, and the neutral not-triggered color from #29622 — which covers 1.4.1 for that component — so our earlier icon swaps were redundant (and would have fought the existing tests). The PR is now scoped to the parts that still add non-color cues: `ColorSchemeLabel` (accessible aria-label instead of an invalid role), `ErrorAlert`, and the `ChartErrorMessage` text prefix. Squashed to a single commit. On checks: pre-commit, lint, frontend-build and the touched component tests (ColorSchemeLabel, ErrorAlert, ChartErrorMessage) are all green. The only red is `sharded-jest-tests (5)` and `(7)` — but those are a **pre-existing failure on master**, not from this PR: `SavedQueryList › "+ Query" … router-relative path` and `TablePreview › refreshes table metadata / shows CREATE VIEW`. They reproduce on a clean `master` checkout (b8b23d6) and fail identically on unrelated PRs of mine — nothing in this diff touches those areas. Ready for the proper look whenever you have a moment — thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
