sadpandajoe opened a new pull request, #41589: URL: https://github.com/apache/superset/pull/41589
fix(calendar): clean up d3-tip tooltips ## SUMMARY - Adds a Calendar Heatmap-specific d3-tip class so tooltip DOM nodes can be cleaned up without affecting other charts. - Removes stale Calendar Heatmap tooltips before redraw and when the React wrapper unmounts. - Destroys the vendor Calendar Heatmap cell and legend d3-tip instances when the calendar is destroyed. Fixes #41583 ## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; tooltip cleanup is covered by a DOM-level regression test. ## TESTING INSTRUCTIONS - `cd superset-frontend && NODE_ENV=test NODE_OPTIONS='--max-old-space-size=8192' npx jest --runInBand --silent plugins/legacy-plugin-chart-calendar/test/tooltip.test.ts plugins/legacy-plugin-chart-calendar/test/utils.test.ts` - `cd superset-frontend && npx oxlint --config oxlint.json plugins/legacy-plugin-chart-calendar/src/Calendar.ts plugins/legacy-plugin-chart-calendar/src/ReactCalendar.tsx plugins/legacy-plugin-chart-calendar/src/tooltip.ts plugins/legacy-plugin-chart-calendar/src/vendor/cal-heatmap.ts plugins/legacy-plugin-chart-calendar/test/tooltip.test.ts` ## ADDITIONAL INFORMATION - [x] Has associated issue: #41583 - [ ] Required feature flags: none - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/9191)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
