aminghadersohi commented on PR #40960: URL: https://github.com/apache/superset/pull/40960#issuecomment-4847757685
@rusackas — you're right, and thank you for the detailed write-up. The race is real: a `reorder=[F1,F2]` validated at T1 can silently drop a filter F3 that another writer committed between T1 and the DAO write at T2, because the DAO's reorder pass only keeps filters in the ordered list. This mirrors the existing REST write behavior (the REST update endpoint has the same gap), so it's not a regression, but it's worth calling out explicitly since an LLM-driven agent could issue frequent reorders. For v1, I've added a concurrency note to the tool docstring in f255d21a09 documenting the limitation and recommending the read-then-compare retry pattern. A proper server-side guard (e.g. compare a hash of `json_metadata` at T1 and T2, rejecting if changed) would require reworking the DAO/command layer and is tracked as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
