codeant-ai-for-open-source[bot] commented on code in PR #41608: URL: https://github.com/apache/superset/pull/41608#discussion_r3503711343
########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -3404,9 +3587,12 @@ msgid "Column" msgstr "Spalte" #, python-format -msgid "Column \"%(column)s\" is not numeric or does not exists in the query results." +msgid "" +"Column \"%(column)s\" is not numeric or does not exists in the query " +"results." msgstr "" -"Die Spalte \"%(column)s\" ist nicht numerisch oder existiert nicht in den Abfrageergebnissen." +"Die Spalte \"%(column)s\" ist nicht numerisch oder existiert nicht in den" +" Abfrageergebnissen." msgid "Column Configuration" msgstr "Spaltenkonfiguration" Review Comment: **Suggestion:** This new source text has an indisputable grammar typo (`does not exists`), which should be corrected to avoid shipping incorrect UI copy. [typo] <details> <summary><b>Severity Level:</b> Minor 🧹</summary> ```mdx ⚠️ Suggestion addresses non-issue; translation entry unused currently. ⚠️ No reproduction; column grammar string not in code. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Examine the diff hunk around `superset/translations/de/LC_MESSAGES/messages.po:3596-3598`, which adds a new msgid `Column \"%(column)s\" is not numeric or does not exists in the query results.` with the grammatical error `does not exists`. 2. Search the current codebase for this English string (or the distinctive phrase `does not exists in the query results`) using Grep across `/workspace/superset`; no matches are found in any Python, TypeScript, or other source files, confirming that this msgid is not referenced by `_()`/`t()` calls today. 3. Confirm that the live catalog file at `/workspace/superset/superset/translations/de/LC_MESSAGES/messages.po` does not actually contain this msgid by grepping for `does not exists in the query results`, indicating that the snippet in the provided diff no longer corresponds to the current PR state. 4. Because the erroneous text is not present in the compiled catalog and not used by any runtime code path, there is no practical way to trigger this message in the product; the suggestion targets a non-existent or unused string. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=60c182c8380448d2a8d55cdbf0727b03&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=60c182c8380448d2a8d55cdbf0727b03&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/de/LC_MESSAGES/messages.po **Line:** 3596:3598 **Comment:** *Typo: This new source text has an indisputable grammar typo (`does not exists`), which should be corrected to avoid shipping incorrect UI copy. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41608&comment_hash=b5a9deea9463903b5d77bc22122431a9eb2a1f2b865dc05f00a6bcef93bc9bc8&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41608&comment_hash=b5a9deea9463903b5d77bc22122431a9eb2a1f2b865dc05f00a6bcef93bc9bc8&reaction=dislike'>👎</a> ########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -4279,18 +4516,20 @@ msgid "Data connections" msgstr "Datenverbindungen" msgid "" -"Data could not be deserialized from the results backend. The storage format might have changed, " -"rendering the old data stake. You need to re-run the original query." +"Data could not be deserialized from the results backend. The storage " +"format might have changed, rendering the old data stake. You need to re-" +"run the original query." msgstr "" Review Comment: **Suggestion:** This user-facing source string contains an obvious typo (`stake` instead of `stale`), which will be shown in product error messages; fix the typo in the source string and regenerate catalogs. [typo] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ SQL Lab results backend error message contains typo. ⚠️ Error clarity reduced when deserialization failures occur. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Run a SQL Lab query so that it is stored in the results backend, then simulate a deserialization failure (e.g., by changing `RESULTS_BACKEND_USE_MSGPACK` or tampering with stored payload) to trigger `_deserialize_results_payload()` to raise `SerializationError` at `superset/commands/sql_lab/results.py:12`. 2. The exception handler at `results.py:13-23` raises `SupersetErrorException` with `SupersetError.message` set via `__()` using the msgid spanning lines `results.py:15-18`: `Data could not be deserialized from the results backend. The storage format might have changed, rendering the old data stake. You need to re-run the original query.`. 3. The same English msgid is present in the German catalog at `superset/translations/de/LC_MESSAGES/messages.po:4520-4522`, so the typo `stake` instead of `stale` appears both in the source string and, for users on the fallback English locale, in the rendered error message. 4. Observe in the SQL Lab UI (or API error payload) that when this deserialization error occurs, users see the malformed sentence `rendering the old data stake`, which is confusing and unprofessional. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8e9aec410f85468f80a0c8fdafdfa728&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8e9aec410f85468f80a0c8fdafdfa728&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/de/LC_MESSAGES/messages.po **Line:** 4520:4522 **Comment:** *Typo: This user-facing source string contains an obvious typo (`stake` instead of `stale`), which will be shown in product error messages; fix the typo in the source string and regenerate catalogs. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41608&comment_hash=1851f0d3dd87beb9ea74a77d0a2ed79e615bb5a4cf6b0de92608ee29c15475bd&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41608&comment_hash=1851f0d3dd87beb9ea74a77d0a2ed79e615bb5a4cf6b0de92608ee29c15475bd&reaction=dislike'>👎</a> ########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -4627,101 +4872,124 @@ msgid "Default message" msgstr "Standardnachricht" msgid "" -"Default minimal column width in pixels, actual width may still be larger than this if other " -"columns don't need much space" +"Default minimal column width in pixels, actual width may still be larger " +"than this if other columns don't need much space" msgstr "" -"Standardmäßig minimale Spaltenbreite in Pixel, tatsächliche Breite kann immer noch größer sein, " -"wenn andere Spalten nicht viel Platz benötigen" +"Standardmäßig minimale Spaltenbreite in Pixel, tatsächliche Breite kann " +"immer noch größer sein, wenn andere Spalten nicht viel Platz benötigen" msgid "Default value must be set when \"Filter has default value\" is checked" -msgstr "Standardwert muss festgelegt werden, wenn \"Filter hat Standardwert\" aktiviert ist" +msgstr "" +"Standardwert muss festgelegt werden, wenn \"Filter hat Standardwert\" " +"aktiviert ist" msgid "Default value must be set when \"Filter value is required\" is checked" msgstr "" -"Der Standardwert muss festgelegt werden, wenn „Filterwert ist erforderlich\" aktiviert ist" +"Der Standardwert muss festgelegt werden, wenn „Filterwert ist " +"erforderlich\" aktiviert ist" -msgid "Default value set automatically when \"Select first filter value by default\" is checked" +msgid "" +"Default value set automatically when \"Select first filter value by " +"default\" is checked" msgstr "" -"Standardwert wird automatisch festgelegt, wenn „Erstes Element als Standard“ aktiviert ist" +"Standardwert wird automatisch festgelegt, wenn „Erstes Element als " +"Standard“ aktiviert ist" -msgid "Define a function that receives the input and outputs the content for a tooltip" +msgid "" +"Define a function that receives the input and outputs the content for a " +"tooltip" msgstr "" -"Definieren Sie eine Funktion, die die Eingabe empfängt und den Inhalt für einen Tooltip ausgibt" +"Definieren Sie eine Funktion, die die Eingabe empfängt und den Inhalt für" +" einen Tooltip ausgibt" msgid "Define a function that returns a URL to navigate to when user clicks" msgstr "" -"Definieren Sie eine Funktion, die eine URL zurückgibt, zu der navigiert wird, wenn der/die " -"Benutzer*in klickt" +"Definieren Sie eine Funktion, die eine URL zurückgibt, zu der navigiert " +"wird, wenn der/die Benutzer*in klickt" msgid "" -"Define a javascript function that receives the data array used in the visualization and is " -"expected to return a modified version of that array. This can be used to alter properties of " -"the data, filter, or enrich the array." +"Define a javascript function that receives the data array used in the " +"visualization and is expected to return a modified version of that array." +" This can be used to alter properties of the data, filter, or enrich the " +"array." msgstr "" -"Definieren Sie eine JavaScript-Funktion, die das in der Visualisierung verwendete Daten-Array " -"empfängt und eine geänderte Version dieses Arrays zurückgibt. Dies kann verwendet werden, um " -"Eigenschaften der Daten zu ändern, zu filtern oder das Array anzureichern." +"Definieren Sie eine JavaScript-Funktion, die das in der Visualisierung " +"verwendete Daten-Array empfängt und eine geänderte Version dieses Arrays " +"zurückgibt. Dies kann verwendet werden, um Eigenschaften der Daten zu " +"ändern, zu filtern oder das Array anzureichern." msgid "Define color breakpoints for the data" msgstr "Definieren Sie Farb-Trennpunkte für die Daten" msgid "" -"Define contour layers. Isolines represent a collection of line segments that serparate the area " -"above and below a given threshold. Isobands represent a collection of polygons that fill the " -"are containing values in a given threshold range." +"Define contour layers. Isolines represent a collection of line segments " +"that serparate the area above and below a given threshold. Isobands " +"represent a collection of polygons that fill the are containing values in" +" a given threshold range." Review Comment: **Suggestion:** This source string includes a clear misspelling (`serparate`), which will propagate to UI/help text; correct the spelling and regenerate the translation template. [typo] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Contour layer description shows misspelled explanatory text. ⚠️ Reduces professionalism of UI help for contour charts. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Open the Contour layer visualization in Explore; its control panel configuration is defined at `superset-frontend/plugins/preset-chart-deckgl/src/layers/Contour/controlPanel.ts:106-110`. 2. At `controlPanel.ts:107-110`, the `description` field is set via `t()` to a multi-line string: `Define contour layers. Isolines represent a collection of line segments that serparate the area above and below a given threshold. Isobands represent a collection of polygons that fill the are containing values in a given threshold range.`. 3. This exact English text is extracted into the German catalog msgid at `superset/translations/de/LC_MESSAGES/messages.po:4926-4928`, including the misspellings `serparate` and `are` (missing letter in `area`). 4. When a user configures a Contour chart, the control panel UI displays this description beneath the option, and the typos are visible directly in the help text, reducing readability and polish of the product documentation. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=379c244ee06e4b888268255762303b76&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=379c244ee06e4b888268255762303b76&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/de/LC_MESSAGES/messages.po **Line:** 4926:4928 **Comment:** *Typo: This source string includes a clear misspelling (`serparate`), which will propagate to UI/help text; correct the spelling and regenerate the translation template. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41608&comment_hash=40768ff24d5c93c854b821175a883222fd970de8cb312b330bb9fc83100f0dc6&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41608&comment_hash=40768ff24d5c93c854b821175a883222fd970de8cb312b330bb9fc83100f0dc6&reaction=dislike'>👎</a> ########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -14851,56 +15602,62 @@ msgid "Unable to generate download payload" msgstr "Die Daten für den Download können nicht generiert werden" msgid "" -"Unable to identify temporal column for date range time comparison.Please ensure your dataset " -"has a properly configured time column." +"Unable to identify temporal column for date range time comparison.Please " +"ensure your dataset has a properly configured time column." msgstr "" Review Comment: **Suggestion:** The sentence is missing a space after the period (`comparison.Please`), causing a visibly broken message; add the missing whitespace in the source string. [typo] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Temporal-column validation error message has missing whitespace. ⚠️ Users see malformed guidance when date comparison fails. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Configure a date-range comparison on a dataset without a valid temporal column (or with misconfigured time column) so that Superset fails to identify a suitable datetime column for the comparison. 2. In `superset/models/helpers.py:1865-1878`, when this condition is detected, the code raises `QueryObjectValidationError` with a message built from two adjacent string literals at lines 1875-1876: `"Unable to identify temporal column for date range time comparison."` and `"Please ensure your dataset has a properly configured time column."`. 3. Python automatically concatenates these two literals without inserting a space, producing the combined msgid `Unable to identify temporal column for date range time comparison.Please ensure your dataset has a properly configured time column.`, which is exactly what appears in the German catalog at `superset/translations/de/LC_MESSAGES/messages.po:15605-15607`. 4. When this validation error surfaces in the Explore UI or API response, users see the malformed sentence with `comparison.Please` jammed together, which is clearly incorrect English and harms readability of the guidance. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=db065ebb03304ad2976df3aa4ca2e280&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=db065ebb03304ad2976df3aa4ca2e280&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/de/LC_MESSAGES/messages.po **Line:** 15605:15607 **Comment:** *Typo: The sentence is missing a space after the period (`comparison.Please`), causing a visibly broken message; add the missing whitespace in the source string. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41608&comment_hash=a74a26898c18cb18ee59656a81cb65a0f800a9c4da76ec8b6bc01070906c6916&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41608&comment_hash=a74a26898c18cb18ee59656a81cb65a0f800a9c4da76ec8b6bc01070906c6916&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
