codeant-ai-for-open-source[bot] commented on code in PR #41609: URL: https://github.com/apache/superset/pull/41609#discussion_r3503744452
########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -256,8 +256,8 @@ msgid "" "%(prefix)sResults truncated to %(row_count)s rows due to memory " "constraints." msgstr "" -"%(prefix)sResultados truncados a %(row_count)s filas por limitaciones " -"en la memoria" +"%(prefix)sResultados truncados a %(row_count)s filas por limitaciones en " +"la memoria" Review Comment: **Suggestion:** This newly backfilled translation is not marked as `fuzzy`, so it will be compiled into `.mo` and shipped immediately instead of staying review-gated like the rest of the AI-generated backfill entries. Add the `#, fuzzy` flag (and attribution comment, if applicable) so it is excluded until human validation. [incomplete implementation] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Spanish memory-constraint warning uses unreviewed AI translation. ⚠️ Backfill workflow guarantee of fuzzy gating broken. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Inspect the Spanish catalog at `superset/translations/es/LC_MESSAGES/messages.po` around PR hunk lines 255–261 (confirmed via Read), where the msgid for the memory truncation warning is declared with `#, python-format` and the msgstr on lines 259–260 contains `"%(prefix)sResultados truncados… la memoria"` but there is no `#, fuzzy` comment attached to this entry. 2. Run the documented command `pybabel compile -d superset/translations -l es`, which compiles `messages.po` into `messages.mo` and, by default, includes all non-fuzzy msgstr entries while skipping fuzzy ones (as noted in the PR description that fuzzy entries are “skipped, as intended”). 3. Start Superset with the locale set to Spanish (`es`) so that translations from `messages.mo` are used for UI strings pulled from the catalog, including the msgid `%(prefix)sResults truncated to %(row_count)s rows due to memory constraints.` defined at lines 15–21 in the same file. 4. Trigger a query that hits the memory truncation path (where the backend calls gettext with that msgid) and observe that the Spanish UI shows the AI-generated translation from lines 259–260 even though this backfilled entry is not marked fuzzy and therefore bypasses the intended human-review gate, unlike nearby machine-translated entries which are all annotated `#, fuzzy`. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2ecf71cc3474471db7b3e7eab9b7973d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2ecf71cc3474471db7b3e7eab9b7973d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/es/LC_MESSAGES/messages.po **Line:** 259:260 **Comment:** *Incomplete Implementation: This newly backfilled translation is not marked as `fuzzy`, so it will be compiled into `.mo` and shipped immediately instead of staying review-gated like the rest of the AI-generated backfill entries. Add the `#, fuzzy` flag (and attribution comment, if applicable) so it is excluded until human validation. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41609&comment_hash=9e772e2bc9f70e365ee8f5e94ff8e9f0b3371836470327c4b3a725220d558370&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41609&comment_hash=9e772e2bc9f70e365ee8f5e94ff8e9f0b3371836470327c4b3a725220d558370&reaction=dislike'>👎</a> ########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -1012,12 +1020,16 @@ msgstr "El informe se ha creado" msgid "API key name is required" msgstr "El nombre del rol es obligatorio" +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, ja, sr, +# sr_Latn] +#, fuzzy msgid "API key revoked successfully" -msgstr "" +msgstr "Clave API revocada correctamente" msgid "API keys allow scoped programmatic access to Superset." -msgstr "Las claves API permiten el acceso programático con " -"ámbito restringido a Superset." +msgstr "" +"Las claves API permiten el acceso programático con ámbito restringido a " +"Superset." Review Comment: **Suggestion:** This added translation is also missing the `fuzzy` marker, which breaks the stated backfill workflow and causes unreviewed AI text to be included in compiled catalogs immediately. Mark it fuzzy until a human reviewer confirms it. [incomplete implementation] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ API key helper text shipped without human review. ⚠️ Inconsistent fuzzy flags on AI backfilled entries. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Inspect `superset/translations/es/LC_MESSAGES/messages.po` around PR hunk lines 1017–1033 (confirmed via Read): the msgid `API keys allow scoped programmatic access to Superset.` at line 1029 now has a Spanish msgstr on lines 1031–1032, but unlike the preceding machine-translated entry `API key revoked successfully` (lines 14–18) there is no `#, fuzzy` marker or “Machine-translated via backfill_po.py” comment attached to this API-keys description. 2. Run `pybabel compile -d superset/translations -l es`, which compiles the Spanish catalog; because this msgstr is not marked fuzzy, Babel includes it in the generated `messages.mo` file while fuzzy backfill entries are excluded by default, contrary to the PR’s stated workflow that all AI backfilled strings remain fuzzy-gated. 3. Start Superset with the locale set to Spanish (`es`) and navigate to the API keys management UI where the help text for API keys is rendered using the msgid `API keys allow scoped programmatic access to Superset.` wired to gettext and the es catalog. 4. Observe that the UI shows the AI-generated Spanish text from lines 1031–1032 (“Las claves API permiten el acceso programático con ámbito restringido a Superset.”) as if it were a fully-reviewed translation, while other nearby backfilled entries remain fuzzy and are gated from compilation, demonstrating that this added translation bypasses the intended fuzzy-review safeguard. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=eece3c4bb5db412791aecd8c9666f4a4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=eece3c4bb5db412791aecd8c9666f4a4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/es/LC_MESSAGES/messages.po **Line:** 1031:1032 **Comment:** *Incomplete Implementation: This added translation is also missing the `fuzzy` marker, which breaks the stated backfill workflow and causes unreviewed AI text to be included in compiled catalogs immediately. Mark it fuzzy until a human reviewer confirms it. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41609&comment_hash=0aedd6054c4146a1b287d92b7df74f82f5d41bddf8c35aee2636eb5e8b8a078d&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41609&comment_hash=0aedd6054c4146a1b287d92b7df74f82f5d41bddf8c35aee2636eb5e8b8a078d&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
