msyavuz opened a new pull request, #41625: URL: https://github.com/apache/superset/pull/41625
### SUMMARY The **Filter results** search box in the SQL Lab results panel stopped filtering the table — typing did nothing. Root cause is in `FilterableTable`: it built the ag-Grid external-filter callback with empty `useCallback` deps reading `filterText` from a ref, so the callback *reference* never changed as the user typed. `GridTable` derives `isExternalFilterPresent` from that reference, so ag-Grid never re-applied the filter. Fix: depend on `filterText` directly so a new value yields a new callback reference and ag-Grid re-runs the (case-insensitive substring) filter. This restores the fix from #38813 that the React 18 upgrade (#38563) reverted. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF _To add._ Before: typing in "Filter results" leaves all rows shown. After: rows filter live to the typed text. ### TESTING INSTRUCTIONS 1. SQL Lab → run any query with multiple rows. 2. Type into the **Filter results** box above the results table. 3. The table filters live to rows matching the text (case-insensitive). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: None - [x] Changes UI — SQL Lab results table filtering - [ ] Includes DB Migration: No - [ ] Introduces new feature or API: No - [ ] Removes existing feature or API: No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
