bito-code-review[bot] commented on PR #41624:
URL: https://github.com/apache/superset/pull/41624#issuecomment-4854990742
<!-- Bito Reply -->
The suggestion to add a return type hint to the new test method is correct,
as it aligns with standard TypeScript practices for React components and test
suites. In TypeScript, test functions that do not return a value should be
explicitly typed as `void` or `Promise<void>` if they are asynchronous.
To resolve this, you can update the test method signature in
`tests/integration_tests/queries/saved_queries/api_tests.py` (or the relevant
test file) to include `: Promise<void>` since the test is `async`.
Would you like me to fetch all other comments on this PR to validate them
and implement fixes for those as well?
**tests/integration_tests/queries/saved_queries/api_tests.py**
```
test('disables the save button when the query name is empty or
whitespace-only', async (): Promise<void> => {
render(<SaveQuery {...mockedProps} />, {
useRedux: true,
store: mockStore(mockState),
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
