codeant-ai-for-open-source[bot] commented on code in PR #41593:
URL: https://github.com/apache/superset/pull/41593#discussion_r3507560035
##########
tests/unit_tests/mcp_service/utils/test_sanitization.py:
##########
@@ -1024,3 +1024,44 @@ def
test_sanitize_sql_expression_allows_url_scheme_in_string_literal():
sanitize_sql_expression = _sanitize_sql()
expr = "COUNT(CASE WHEN url LIKE 'javascript:%' THEN 1 END)"
assert sanitize_sql_expression(expr, "sql_expression") == expr
+
+
+# ---------------------------------------------------------------------------
+# escape_like
+# ---------------------------------------------------------------------------
+
+
+def test_escape_like_plain_text():
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag missing return type annotations for new test functions in this
file unless the entire file is being standardized at once.
**Applied to:**
- `tests/unit_tests/mcp_service/utils/test_sanitization.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
tests/unit_tests/mcp_service/system/tool/test_find_users.py:
##########
@@ -255,3 +255,84 @@ async def
test_list_charts_passes_changed_by_fk_filter_to_dao(mock_list, mcp_ser
forwarded_filters = mock_list.call_args.kwargs.get("column_operators")
assert forwarded_filters is not None
assert any(getattr(f, "col", None) == "changed_by_fk" for f in
forwarded_filters)
+
+
+# ---------------------------------------------------------------------------
+# LIKE wildcard escaping tests
+# ---------------------------------------------------------------------------
+
+
[email protected]
+async def test_find_users_escapes_percent_wildcard(mcp_server):
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag missing type annotations on test functions in
tests/unit_tests/mcp_service/; tests in this area intentionally omit parameter
and return type hints for consistency.
**Applied to:**
- `tests/unit_tests/mcp_service/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
