bito-code-review[bot] commented on PR #41590:
URL: https://github.com/apache/superset/pull/41590#issuecomment-4858341581
<!-- Bito Reply -->
The suggestion to add explicit type annotations to the temporal boundary
variables is correct, as it improves code clarity and adheres to strict typing
standards. You can resolve this by explicitly annotating the `start` and `end`
variables returned by `get_since_until_from_time_range`.
Here is the corrected implementation for
`superset/semantic_layers/mapper.py`:
```python
start: datetime | None
end: datetime | None
start, end = get_since_until_from_time_range(time_range=value)
```
There are no other comments on this PR to address. Would you like me to
review any other parts of the code?
**superset/semantic_layers/mapper.py**
```
start: datetime | None
end: datetime | None
start, end = get_since_until_from_time_range(time_range=value)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
