aminghadersohi commented on PR #39922: URL: https://github.com/apache/superset/pull/39922#issuecomment-4858769992
Thanks @fitzee — all four items addressed in 9e55ba0ffbab8339638b2fc7f5005829034c8954: **MEDIUM — `pivot_table.py` test coverage:** Added `TestNormalizePivotTableColumnRefs` to `test_column_name_normalization.py` with 6 cases covering rows, columns, metrics, filters, saved_metric canonical rename, and sql_expression passthrough (no crash on `name=None`). **LOW — `get_runtime_warnings()` suggestions/warnings conflation:** Widened the `ChartTypePlugin` Protocol return type from `list[str]` to `tuple[list[str], list[str]]`. Updated `BaseChartPlugin` default, `XYChartPlugin` implementation (cardinality suggestions now go to the `suggestions` list, not `warnings`), and `RuntimeValidator._validate_plugin_runtime` caller to unpack the tuple. Updated the test mocks accordingly. **LOW — 14 formatting-churn files:** Restored all 7 remaining out-of-scope files to master state via `git checkout origin/master`: `advanced_data_type/plugins/internet_address.py`, `internet_port.py`, `datasets/api.py`, `datasource/api.py`, `utils/excel.py`, `utils/mock_data.py`, `views/log/api.py`. **LOW — PR description corrections:** - "silently skipped column validation" → "skipped normalization — case mismatches surfaced only at query time. Column *existence* checks were already in place for all 7 types" - "5-type column validation gap" → "5-type column normalization gap" - Removed `initialization/__init__.py` from the `registry.configure()` wiring claim; corrected to `flask_singleton.py` only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
