bito-code-review[bot] commented on code in PR #41641: URL: https://github.com/apache/superset/pull/41641#discussion_r3509354065
########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -4754,8 +4801,11 @@ msgstr "ยกเลิก" msgid "Cancel query on window unload event" msgstr "ยกเลิกคำค้นหาเมื่อเกิดเหตุการณ์ปิดหน้าต่าง" +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, es, sr, +# sr_Latn] +#, fuzzy msgid "Cancellation not available due to missing abort handler" -msgstr "" +msgstr "ไม่สามารถยกเลิกได้เนื่องจากไม่มี abort handler" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Fuzzy flag blocks Thai localization</b></div> <div id="fix"> Error message for missing abort handler (lines 4807-4808) is also marked `fuzzy` — Thai users will see the English error message at runtime until reviewed. </div> </div> <small><i>Code Review Run #a5fe15</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -4470,6 +4506,11 @@ msgstr "ผู้รับสำเนา (CC)" msgid "COPY QUERY" msgstr "คัดลอกคิวรี" +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: lv] +#, fuzzy +msgid "Copy query" +msgstr "คัดลอกคิวรี" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Fuzzy flag blocks Thai localization</b></div> <div id="fix"> This entry is marked `fuzzy`, meaning gettext tools will skip it at compile time and fall back to the English source string at runtime. Users running Thai locale will see "Copy query" in English until a translator reviews and removes the `fuzzy` flag. Consider prioritizing human review for this entry to deliver the intended localized UX. </div> </div> <small><i>Code Review Run #a5fe15</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -1257,13 +1269,19 @@ msgstr "ฟังก์ชัน JavaScript ที่สร้างออบเ msgid "A JavaScript function that generates an icon configuration object" msgstr "ฟังก์ชัน JavaScript ที่สร้างออบเจกต์การกำหนดค่าไอคอน" -#, python-brace-format +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr, +# sr_Latn] +#, fuzzy, python-brace-format msgid "" "A JavaScript object that adheres to the ECharts options specification, " "overriding other control options with higher precedence. (i.e. { title: {" " text: \"My Chart\" }, tooltip: { trigger: \"item\" } }). Details: " "https://echarts.apache.org/en/option.html. " msgstr "" +"ออบเจกต์ JavaScript ที่สอดคล้องกับข้อกำหนดตัวเลือก ECharts " +"โดยแทนที่ตัวเลือกการควบคุมอื่นๆ ด้วยลำดับความสำคัญที่สูงกว่า (เช่น { " +"title: { text: \"My Chart\" }, tooltip: { trigger: \"item\" } }) " +"รายละเอียด: https://echarts.apache.org/en/option.html. " Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Correct translation marked fuzzy</b></div> <div id="fix"> The ECharts entry is marked `#, fuzzy` (line 1274) despite having an accurate, complete Thai translation. The `#, fuzzy` flag suppresses the translation at runtime, causing the English source string to be shown to Thai users even though a correct translation exists. Remove the `#, fuzzy` flag so the translation is activated. </div> </div> <small><i>Code Review Run #a5fe15</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -23666,10 +23885,15 @@ msgstr "ไม่สามารถสร้างแท็กได้" msgid "Task could not be updated." msgstr "ไม่สามารถอัปเดตแท็กได้" +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr, +# sr_Latn] +#, fuzzy msgid "" "Task is not abortable. The task is in progress but has not registered an " "abort handler." msgstr "" +"ไม่สามารถยกเลิกงานได้ " +"งานกำลังดำเนินการอยู่แต่ยังไม่ได้ลงทะเบียนตัวจัดการการยกเลิก" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Machine translations left fuzzy</b></div> <div id="fix"> These 4 entries are marked `fuzzy`, causing gettext to ignore the Thai translations and fall back to English for all 3 strings. Add a follow-up commit removing the `fuzzy` flag once a translator verifies the translations. </div> </div> <small><i>Code Review Run #a5fe15</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -30923,8 +31247,11 @@ msgstr "แผนที่ความร้อน" msgid "heatmap: values are normalized across the entire heatmap" msgstr "แผนที่ความร้อน: ค่าต่างๆ ถูกทำให้เป็นมาตรฐานทั่วทั้งแผนที่ความร้อน" +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr, +# sr_Latn] +#, fuzzy msgid "hello" -msgstr "" +msgstr "สวัสดี" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Unreviewed fuzzy machine translations</b></div> <div id="fix"> This diff adds 9 new `#, fuzzy` entries (covering ~30 msgid strings) to the Thai `.po` file. Per the documented backfill_po.py workflow (howtos.md lines 403–408), all fuzzy entries must be individually reviewed for translation accuracy and UI-context correctness, and the fuzzy flag + attribution comment removed after approval. Verify each new entry before the PR is merged — unfinalized fuzzy entries are excluded from compiled `.mo` files and won't be visible to users. </div> </div> <small><i>Code Review Run #a5fe15</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -29833,8 +30142,11 @@ msgstr "คุณต้องเลือกชื่อสำหรับแด msgid "You must run the query successfully first" msgstr "คุณต้องรันคิวรีให้สำเร็จก่อน" +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr, +# sr_Latn] +#, fuzzy msgid "You need to" -msgstr "" +msgstr "คุณต้อง" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incomplete translation stub rendered to users</b></div> <div id="fix"> The `msgid` at line 30148 is the truncated fragment `You need to` with no trailing text block. The `msgstr` "คุณต้อง" correctly translates that stub, but the UI will render the broken fragment. The `#, fuzzy` flag signals review is needed — this entry should either be removed or replaced with a complete phrase that matches what the UI actually passes to the translator. </div> </div> <small><i>Code Review Run #a5fe15</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -5132,9 +5182,11 @@ msgstr "อักขระที่ใช้แทนจุดทศนิยม msgid "Chart" msgstr "แผนภูมิ" -#, python-format +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr, +# sr_Latn] +#, fuzzy, python-format msgid "Chart %(chart_id)s is not on dashboard %(dashboard_id)s" -msgstr "" +msgstr "แผนภูมิ %(chart_id)s ไม่ได้อยู่บนแดชบอร์ด %(dashboard_id)s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Fuzzy flag blocks Thai localization</b></div> <div id="fix"> Formatted error message (lines 5188-5189) is also marked `fuzzy` — Thai users will see the English error at runtime until reviewed. </div> </div> <small><i>Code Review Run #a5fe15</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -4528,11 +4569,17 @@ msgstr "แม่แบบ CSS" msgid "CSS applied to the chart" msgstr "CSS ที่ใช้กับแผนภูมิ" +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr, +# sr_Latn] +#, fuzzy msgid "" "CSS styles may be removed by server-side HTML sanitization. If styles are" " not applying, ask your Superset administrator to adjust the HTML " "sanitization configuration." msgstr "" +"สไตล์ CSS อาจถูกลบออกโดยการทำความสะอาด HTML ฝั่งเซิร์ฟเวอร์ " +"หากสไตล์ไม่ถูกนำไปใช้ ให้ติดต่อผู้ดูแลระบบ Superset " +"เพื่อปรับการตั้งค่าการทำความสะอาด HTML" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Fuzzy flag blocks Thai localization</b></div> <div id="fix"> Multi-line message block (lines 4575-4582) is also marked `fuzzy` — the translated message describes a server-side HTML sanitization behavior and its workaround. Thai users will see the English version until reviewed. </div> </div> <small><i>Code Review Run #a5fe15</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
