sadpandajoe commented on code in PR #40984:
URL: https://github.com/apache/superset/pull/40984#discussion_r3509598026
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx:
##########
@@ -1659,6 +1659,61 @@ test('renders standard Select dropdown when operatorType
is Exact', () => {
expect(screen.getAllByRole('combobox').length).toBeGreaterThan(0);
});
+test('shows create option for multi-select creatable filter when typing',
async () => {
+ getWrapper({ creatable: true, multiSelect: true });
Review Comment:
`getWrapper` is scoped inside the earlier `describe('SelectFilterPlugin',
...)` block, which closes around line 718. These new tests are outside that
scope, so `oxlint` fails with `'getWrapper' is not defined` for lines 1663 and
1669. Move the tests inside the describe block, hoist `getWrapper`, or rewrite
them using the top-level `buildSelectFilterProps` helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
