bito-code-review[bot] commented on PR #41648:
URL: https://github.com/apache/superset/pull/41648#issuecomment-4861070554
<!-- Bito Reply -->
The flagged issue is correct. Piping `pybabel compile` to `true` masks any
compilation errors, which can lead to silent failures where the Docker build
succeeds despite missing or incomplete translation files.
To resolve this, you should remove the pipe to `true` and allow the command
to exit with its native status. If you want to ensure the build continues even
on failure, you should explicitly handle the error or use `|| true` only if you
have verified that failure is acceptable in that specific context.
### Proposed Fix
In `Dockerfile`, update the `RUN` command to remove the pipe:
```dockerfile
RUN if [ "${BUILD_TRANSLATIONS}" = "true" ]; then \
pybabel compile --use-fuzzy -d /app/translations_mo; \
fi; \
rm -f /app/translations_mo/*/*/*.[po,json]
```
There are no other comments in this pull request to address.
**Dockerfile**
```
RUN if [ "${BUILD_TRANSLATIONS}" = "true" ]; then \
pybabel compile --use-fuzzy -d /app/translations_mo; \
fi; \
rm -f /app/translations_mo/*/*/*.[po,json]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
