codeant-ai-for-open-source[bot] commented on code in PR #41649:
URL: https://github.com/apache/superset/pull/41649#discussion_r3509751292
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -17773,12 +18210,19 @@ msgid "std"
msgstr "стандартное отклонение"
# Не переводить
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, ja, lv, mi, nl, pt_BR, ro, sk, sl, sr, sr_Latn, tr, uk]
+#, fuzzy
msgid "step-after"
-msgstr ""
+msgstr "шаг-после"
# Не переводить
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ro, sk, sl, sr, sr_Latn, tr, uk,
+# zh, zh_TW]
+#, fuzzy
msgid "step-before"
-msgstr ""
+msgstr "шаг-до"
Review Comment:
**Suggestion:** The `step-before` token is under a non-translate marker, but
the translation altered it. This should stay literal to avoid invalid
option/value submission. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ NVD3 interpolation label diverges from reserved token.
⚠️ Russian catalog ignores non-translatable flag for step-before.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In `superset/translations/ru/LC_MESSAGES/messages.po` (verified via Read
at offset
~18208), locate the "step-before" entry directly beneath the "step-after"
block; it is
also preceded by "# Не переводить" and machine-translation comments, marking
it as
non-translatable.
2. At approximately line 18225 (verified via Grep), confirm this entry reads
`msgid
"step-before"` with `msgstr "шаг-до"`, so the Russian catalog translates a
token that
translators were instructed not to change.
3. Review
`superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx:126-129`,
where
the NVD3 line interpolation options are constructed as `['step-before',
t('step-before')]`
and `['step-after', t('step-after')]`, using the literal string as the
internal value and
gettext for the label.
4. With the Russian locale compiled (`pybabel compile --use-fuzzy -d
superset/translations
-l ru`), the NVD3 interpolation control renders the `'step-before'` option
label as
"шаг-до" while the underlying value remains 'step-before'; this preserves
functionality
but creates a mismatch between the reserved keyword and the label, contrary
to the
non-translate comment and potentially confusing users referencing external
documentation
that uses the literal token.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fc5188597dcc40bba682ba2e85976850&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fc5188597dcc40bba682ba2e85976850&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/ru/LC_MESSAGES/messages.po
**Line:** 18225:18225
**Comment:**
*Comment Mismatch: The `step-before` token is under a non-translate
marker, but the translation altered it. This should stay literal to avoid
invalid option/value submission.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=8252d2642d331d08d000587cabc10177c3fe4b7b3dc0e25d0b1b46cf666b43db&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=8252d2642d331d08d000587cabc10177c3fe4b7b3dc0e25d0b1b46cf666b43db&reaction=dislike'>👎</a>
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -17087,8 +17475,12 @@ msgid "bfill"
msgstr "bfill (заполняет пропуски предыдущими значениями)"
# Не переводить
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, fr, ja, lv, mi, nl, pl, pt, pt_BR, ro, sk, sl, sr, sr_Latn, tr,
+# uk, zh, zh_TW]
+#, fuzzy
msgid "bolt"
-msgstr ""
+msgstr "болт"
Review Comment:
**Suggestion:** The entry is explicitly marked as non-translatable, but the
token was translated. This can break any workflow that expects the literal
`bolt` keyword/value; keep the translation identical to the source token.
[comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ Explore control header shows mistranslated bolt label.
⚠️ Russian catalog disobeys explicit do-not-translate comment.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Inspect `superset/translations/ru/LC_MESSAGES/messages.po` around line
17476 (verified
via Read), where the entry for msgid "bolt" is preceded by a "# Не
переводить" comment
indicating it must not be translated.
2. Observe that the same entry has `msgid "bolt"` and `msgstr "болт"` at
approximately
line 17483 (verified via Grep), so the Russian catalog translates a string
explicitly
marked as non-translatable.
3. In the frontend,
`superset-frontend/src/explore/components/ControlHeader.tsx:13-18`
uses `label={t('bolt')}` within the `InfoTooltip` component to render a
label for controls
whose changes take effect instantly (verified via Read).
4. When Superset runs with locale `ru` and the Explore UI renders a control
header with
`renderTrigger` enabled, the label obtained from `t('bolt')` displays the
translated
"болт" instead of the literal "bolt", contradicting the non-translate
comment and
potentially confusing users who expect the reserved token.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8bb642876de647de834eb0123c3a0da1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8bb642876de647de834eb0123c3a0da1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/ru/LC_MESSAGES/messages.po
**Line:** 17483:17483
**Comment:**
*Comment Mismatch: The entry is explicitly marked as non-translatable,
but the token was translated. This can break any workflow that expects the
literal `bolt` keyword/value; keep the translation identical to the source
token.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=051e1d802a3bb9252814309dc9020d5cd0d5d22548fc27c58e7beabdc3f82196&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=051e1d802a3bb9252814309dc9020d5cd0d5d22548fc27c58e7beabdc3f82196&reaction=dislike'>👎</a>
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -17360,8 +17758,11 @@ msgid "error"
msgstr "ошибка"
# Не переводить
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, ja, lv, mi, nl, pt_BR, ro, sk, sl, sr, sr_Latn, tr, uk]
+#, fuzzy
msgid "error_message"
-msgstr ""
+msgstr "сообщение_об_ошибке"
Review Comment:
**Suggestion:** This string is marked `# Не переводить`, but the key-like
identifier was translated. `error_message` is typically a machine-consumed
field name and should remain unchanged to avoid contract mismatches. [comment
mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ Russian catalog mislabels error_message OpenAPI field name.
⚠️ Developers may copy localized key, breaking API contracts.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In `superset/translations/ru/LC_MESSAGES/messages.po` around line 17757
(verified via
Read), locate the entry for msgid "error_message" which is preceded by a "#
Не переводить"
comment, marking it as a non-translatable identifier.
2. At approximately line 17765 (verified via Grep), observe that this entry
uses `msgid
"error_message"` and `msgstr "сообщение_об_ошибке"`, i.e. the key-like
identifier is
translated despite the non-translate directive.
3. Review `docs/static/resources/openapi.json` where "error_message" appears
as a property
name in multiple schemas (e.g. lines 216, 7369, 7934, 7981, and example at
12777, verified
via Grep), indicating it is a machine-consumed field name in the API
contract.
4. After compiling Russian translations with `pybabel compile --use-fuzzy -d
superset/translations -l ru`, any UI or helper text that calls gettext on
msgid
"error_message" will show the localized "сообщение_об_ошибке";
Russian-speaking developers
may copy this localized string into configurations or client code, causing
mismatches with
APIs that expect the literal "error_message" field defined in `openapi.json`.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=34de457b50f1487097161b927c60fb0f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=34de457b50f1487097161b927c60fb0f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/ru/LC_MESSAGES/messages.po
**Line:** 17765:17765
**Comment:**
*Comment Mismatch: This string is marked `# Не переводить`, but the
key-like identifier was translated. `error_message` is typically a
machine-consumed field name and should remain unchanged to avoid contract
mismatches.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=cf65ef4186a0c26213bfa00c7de613e9343ff082ac02359d65505a5d78e95566&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=cf65ef4186a0c26213bfa00c7de613e9343ff082ac02359d65505a5d78e95566&reaction=dislike'>👎</a>
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -17773,12 +18210,19 @@ msgid "std"
msgstr "стандартное отклонение"
# Не переводить
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, ja, lv, mi, nl, pt_BR, ro, sk, sl, sr, sr_Latn, tr, uk]
+#, fuzzy
msgid "step-after"
-msgstr ""
+msgstr "шаг-после"
Review Comment:
**Suggestion:** The `step-after` value is marked as non-translatable but was
translated, which can invalidate enum/option matching where the exact token is
required. Keep this value unchanged. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ NVD3 interpolation label diverges from reserved token.
⚠️ Russian catalog ignores non-translatable flag for step-after.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open `superset/translations/ru/LC_MESSAGES/messages.po` near the "std"
entry (offset
~18208, verified via Read); below it, find the block where msgid
"step-after" is preceded
by "# Не переводить" and machine-translation metadata, indicating this token
should not be
localized.
2. At approximately line 18217 (verified via Grep), confirm that the entry
is `msgid
"step-after"` with `msgstr "шаг-после"`, meaning the Russian catalog
translates a string
explicitly marked non-translatable.
3. In the frontend, inspect
`superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx:126-129`
(verified via Grep and Read), where line interpolation options are defined as
`['step-before', t('step-before')]` and `['step-after', t('step-after')]`
for NVD3 line
charts.
4. When a Russian user edits a legacy NVD3 line chart, the interpolation
control uses
`t('step-after')` to render the option label; the UI shows "шаг-после"
instead of the
literal "step-after", diverging from the reserved keyword documented by the
chart library
and contradicting the non-translate comment, which can confuse users mapping
UI options to
underlying interpolation modes.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fd717cda7af34eba91dba8c039c4dad3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fd717cda7af34eba91dba8c039c4dad3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/ru/LC_MESSAGES/messages.po
**Line:** 18217:18217
**Comment:**
*Comment Mismatch: The `step-after` value is marked as non-translatable
but was translated, which can invalidate enum/option matching where the exact
token is required. Keep this value unchanged.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=1acde123681ed41bcc0e80c6c43448f1e6f63f56d3584145f5846984f3873a11&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=1acde123681ed41bcc0e80c6c43448f1e6f63f56d3584145f5846984f3873a11&reaction=dislike'>👎</a>
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -17914,14 +18364,20 @@ msgid "year"
msgstr "год"
# Не переводить
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja,
+# lv, sk, sr, sr_Latn, tr, uk]
+#, fuzzy
msgid "your-project-1234-a1"
-msgstr ""
+msgstr "ваш-проект-1234-a1"
Review Comment:
**Suggestion:** This sample identifier is marked non-translatable, but it
was localized. Keeping placeholder IDs literal avoids misleading users into
entering localized values that fail validation. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
⚠️ Database connection form placeholder localizes sample project ID.
⚠️ Russian catalog contradicts non-translatable placeholder guidance.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Inspect `superset/translations/ru/LC_MESSAGES/messages.po` around the
"year" entry
(offset ~18360, verified via Read); immediately after it, find the block for
msgid
"your-project-1234-a1" preceded by "# Не переводить", marking the sample
identifier as
non-translatable.
2. At approximately line 18371 (verified via Grep), observe that this entry
uses `msgid
"your-project-1234-a1"` with `msgstr "ваш-проект-1234-a1"`, so the Russian
catalog
localizes a placeholder that translators were instructed to keep identical.
3. In the database connection UI,
`superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx:15-27`
defines `projectIdfield`, whose `ValidatedInput` uses
`placeholder={t('your-project-1234-a1')}` and `label={t('Project Id')}`
(verified via
Read).
4. When a Russian-speaking user configures a database connection, the
Project Id field’s
placeholder shows the localized "ваш-проект-1234-a1" instead of the literal
example; this
contradicts the non-translate guidance and may mislead users into entering
localized
values that do not match actual provider project ID formats.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a3d5887ef8f1425cbba2dd1a2a1ff38a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a3d5887ef8f1425cbba2dd1a2a1ff38a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/ru/LC_MESSAGES/messages.po
**Line:** 18371:18371
**Comment:**
*Comment Mismatch: This sample identifier is marked non-translatable,
but it was localized. Keeping placeholder IDs literal avoids misleading users
into entering localized values that fail validation.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=d06fe0d1aa77a0733b3aecf5f3d60c82f327b751c430ebf7844a35378f292987&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41649&comment_hash=d06fe0d1aa77a0733b3aecf5f3d60c82f327b751c430ebf7844a35378f292987&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
