sadpandajoe opened a new pull request, #41650:
URL: https://github.com/apache/superset/pull/41650

   ### SUMMARY
   Fixes the current master CI regressions observed across recent master runs:
   
   - Update stale unit-test patches to target the real module objects instead 
of package exports that shadow submodules with function objects.
   - Give the dataset creation Playwright spec the existing slow-test timeout 
budget, matching the work it performs in CI.
   - Type intentional invalid semantic-layer test inputs as `Any` so mypy 
accepts the negative cases without changing test behavior.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Not applicable; this is a test-only CI stabilization change.
   
   ### TESTING INSTRUCTIONS
   - `PATH=/Users/joeli/.nvm/versions/node/v24.16.0/bin:$PATH pre-commit run 
--files superset-frontend/playwright/tests/dataset/create-dataset.spec.ts 
tests/unit_tests/semantic_layers/mapper_test.py 
tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py 
tests/unit_tests/pandas_postprocessing/test_prophet.py`
   - `PATH=/Users/joeli/.nvm/versions/node/v24.16.0/bin:$PATH pre-commit run`
   - `pytest 
tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py 
tests/unit_tests/pandas_postprocessing/test_prophet.py::test_prophet_fit_error 
tests/unit_tests/semantic_layers/mapper_test.py -q` was attempted locally, but 
this worktree fails during test collection before these tests run because local 
`sqlglot`/Dremio imports raise `TypeError: Cannot create a consistent method 
resolution order (MRO) for bases Expression, Func`.
   - `pre-commit run --all-files` was attempted locally; it is blocked in this 
environment by docs/helm/frontend build prerequisites and an unrelated 
all-files `ruff` C901 finding in 
`superset/mcp_service/sql_lab/tool/execute_sql.py`. The latest master 
`pre-commit checks` Action is green, so CI remains the source of truth for the 
full matrix.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to