bito-code-review[bot] commented on code in PR #41655:
URL: https://github.com/apache/superset/pull/41655#discussion_r3510235319
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -6234,9 +6452,11 @@ msgstr ""
msgid "Error deleting %s"
msgstr "Une erreur s'est produite durant la récupération des données : %s"
-#, python-format
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, es, sr,
+# sr_Latn]
+#, fuzzy, python-format
msgid "Error disabling fullscreen: %s"
-msgstr ""
+msgstr "Erreur lors de la désactivation du plein écran : %s"
#, fuzzy, python-format
msgid "Error enabling fullscreen: %s"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong translation for Error enabling fullscreen</b></div>
<div id="fix">
The msgstr for `Error enabling fullscreen: %s` duplicates the translation of
`Error deleting %s` ("Une erreur s'est produite durant la récupération des
données"), which means "error fetching data" — entirely wrong for an
enabling-fullscreen action. It also mismatches the adjacent `Error disabling
fullscreen: %s` translation at line 6458 ("Erreur lors de la désactivation du
plein écran"). The correct translation is "Erreur lors de l'activation du plein
écran : %s".
</div>
</div>
<small><i>Code Review Run #953ee6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -6030,15 +6227,21 @@ msgstr "Activer les prévisions"
msgid "Enable graph roaming"
msgstr "Activer le déplacement graphique"
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja,
+# lv, pt_BR, ru, sk, sr, sr_Latn, tr, uk]
+#, fuzzy
msgid "Enable icon JavaScript mode"
-msgstr ""
+msgstr "Activer le mode JavaScript pour les icônes"
#, fuzzy
msgid "Enable icons"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong translation for Enable icons</b></div>
<div id="fix">
The msgstr for `Enable icons` reads "Colonnex du tableau" (literally "Table
columns"), which is an unrelated error from a prior human translator. The new
backfill translation correctly translated the adjacent `Enable icon JavaScript
mode` as "Activer le mode JavaScript pour les icônes" but missed this entry.
The correct French for "Enable icons" is "Activer les icônes".
</div>
</div>
<small><i>Code Review Run #953ee6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -6510,8 +6733,11 @@ msgstr "Échec de l'export, veuillez réessayer."
msgid "Export failed: %s"
msgstr "Rapport échoué"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing printf placeholder in translation</b></div>
<div id="fix">
The msgid "Export failed: %s" has a `#, fuzzy, python-format` flag, but the
msgstr is missing the %s placeholder. The usage at
`superset-frontend/src/SqlLab/components/ResultSet/index.tsx:243` calls
`addDangerToast(t('Export failed: %s', error))`, passing error as a
substitution argument. At runtime, the error detail will be silently dropped,
producing "Rapport échoué" instead of the intended "Rapport échoué: <actual
error>".
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
msgstr "Échec de l'exportation : %s"
````
</div>
</details>
</div>
<small><i>Code Review Run #953ee6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -8680,8 +8983,11 @@ msgstr "Mapbox"
msgid "Mapbox (API key required)"
msgstr "le courriel est obligatoire"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Cross-contaminated translation</b></div>
<div id="fix">
The msgstr for `"Mapbox (API key required)"` reads "le courriel est
obligatoire" (email is mandatory), which has no semantic relation to the
English source. This is a cross-contamination from a different source string.
Fix: "Mapbox (clé API requise)".
</div>
</div>
<small><i>Code Review Run #953ee6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
