rish106-hub opened a new pull request, #41731:
URL: https://github.com/apache/superset/pull/41731

   ## SUMMARY
   Chart tiles (\`.dashboard-component-chart-holder\`) never rendered a border 
at rest in any theme -- the only border declaration lived in the transient 
\`.fade-out\` state and defaulted to \`none\`. This moves 
\`border\`/\`border-radius\` to the base rule using the existing 
\`theme.dashboardTileBorder ?? colorBorder\` fallback pattern, mirroring the 
precedent set in #35199 for the header divider.
   
   ## BEFORE/AFTER
   Before: no visible boundary between chart tiles or tile-to-canvas in any 
theme.
   After: tiles render a 1px border using \`theme.colorBorder\` (or the 
\`dashboardTileBorder\` override if set), switching automatically with theme 
changes.
   
   ## TESTING INSTRUCTIONS
   - \`npm run test -- 
src/dashboard/components/DashboardBuilder/DashboardBuilder.test.tsx\` (28/28 
pass, includes new test for this fix)
   - Manually: open a dashboard, toggle a custom theme with a visible 
\`colorBorder\`, confirm tile boundaries render and the fade-in/fade-out 
filter-focus and resize effects still layer correctly on top.
   
   ## ADDITIONAL INFORMATION
   - Fixes #41618
   - Related PRs on this issue with open gaps at time of writing: #41661 
(correct approach, failing pre-commit), #41699 (merge conflict, no tests)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to