rusackas opened a new pull request, #41738: URL: https://github.com/apache/superset/pull/41738
### SUMMARY Tier 3 of #41714 (targets `remove-legacy-viz-pipeline`): retire the nvd3 **Time-series Percent Change (`compare`)** chart by migrating saved charts to the ECharts **Line Chart (`echarts_timeseries_line`)**. - New `MigrateCompareChart` processor — the shared `TimeseriesChart` base already handles the whole nvd3 timeseries control mapping (including normalizing the legacy `absolute` comparison type), so the subclass only declares the source/target viz types. Registered with the `superset viz-migrations` CLI and covered by a unit test. - Alembic revision `e5f6a7b8c9d0` (chained after the bubble migration) with the standard MySQL MEDIUMTEXT widening and reversible `form_data_bak` backups. - Removes the nvd3 Compare plugin, its MainPreset/preset registrations, the `NVD3CompareTimeSeriesViz` backend class, and the cumulative-line branch of the shared NVD3 renderer. - **Behavior note for UPDATING.md**: the nvd3 renderer's *interactive re-basing* (clicking a point to re-base percent change) is not preserved by the ECharts line chart. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Saved Percent Change charts re-open as ECharts Line Charts. ### TESTING INSTRUCTIONS - `pytest tests/unit_tests/migrations/viz/nvd3_compare_chart_to_echarts_test.py` passes. - `npm run test -- plugins/legacy-preset-chart-nvd3` passes. - Manual: `superset db upgrade` then open a formerly-`compare` chart — renders as an ECharts line chart; `superset db downgrade` restores the original form_data. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [x] Migration is atomic, supports rollback & is backwards-compatible - [x] Confirm DB migration upgrade and downgrade tested - [x] Runtime estimates and downtime expectations provided: proportional to the number of saved `compare` slices; no downtime expected - [ ] Introduces new feature or API - [x] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
