EnxDev commented on PR #39118:
URL: https://github.com/apache/superset/pull/39118#issuecomment-4874615713
## EnxDev's Review Agent — apache/superset#39118 · HEAD d6cd699
comment — the rename is complete and behavior-neutral against the branch's
base, but one new occurrence of the old name landed on master after the last
rebase; one more rebase + one-line fix and this is mergeable.
I verified the rename against master rather than taking the diff at face
value: grepped the whole repo for `superset_can_csv`, `supersetCanCSV`, and
`superset-can-csv`. All occurrences are covered by the 8 changed files, with
one exception below. `superset_can_download` still reads
`findPermission('can_csv', 'Superset', roles)`, so there is no permission
behavior change — the `can_export_data` switch that earned the
`risk:breaking-change` label and the April changes-requested review is gone
from this HEAD. The label looks droppable, and the stale changes-requested
review should be dismissed or re-requested so it doesn't block merge. The
translation-regression warning also predates the June 28 rebase — this diff
touches no translatable strings.
### 🟡 Should-fix
-
**`superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.subdirectory.test.tsx:101`**
— still passes `supersetCanCSV: true`. This file landed on master Jul 1
(#39925), after this branch's Jun 28 rebase, so the rename couldn't have caught
it. Post-merge the old prop survives as a silent no-op: the `as unknown as
SliceHeaderControlsProps` cast hides it from tsc, and the file's tests only
exercise "Edit chart" (gated by `supersetCanExplore`), so nothing fails in CI.
Rebase and rename this one occurrence.
### 🔵 Nits
- PR title ends with a literally truncated `(#2…` — spell it out as
`(#24290)` or drop it (the squash-merge commit message inherits the title).
### 🙌 Praise
- Reverting the `can_export_data` switch to keep this PR a pure
single-responsibility rename was the right call — it resolves the breaking
scenario @sadpandajoe described without losing the follow-up.
<!-- enxdev-review-agent:d6cd699 -->
_Reviewed by EnxDev's Review Agent — @EnxDev · HEAD d6cd699._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
