bito-code-review[bot] commented on code in PR #41722: URL: https://github.com/apache/superset/pull/41722#discussion_r3518820228
########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -2599,6 +2599,9 @@ msgstr "最近" msgid "COPY QUERY" msgstr "复制查询URL" +msgid "Copy query" +msgstr "" Review Comment: <!-- Bito Reply --> The suggestion is correct in identifying that an empty `msgstr` will result in no text being displayed for that label in the Chinese locale. While it is common practice to leave new strings untranslated initially, explicitly providing an empty string can cause UI issues depending on how the translation system handles missing keys. If you prefer to keep the entry for future translation, you may want to provide a placeholder or the English source string as a fallback. **superset/translations/zh/LC_MESSAGES/messages.po** ``` msgid "Copy query" msgstr "" ``` ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -6536,6 +6539,9 @@ msgstr "二月" msgid "FIT DATA" msgstr "编辑数据集" +msgid "Fit data" +msgstr "" Review Comment: <!-- Bito Reply --> The reviewer's suggestion is based on the assumption that an empty `msgstr` results in a blank label for the user. However, as noted in the thread, an empty `msgstr` in gettext-based translation files typically causes the system to fall back to the English source string rather than rendering nothing. Given this behavior, the suggestion is not necessary for functional correctness in this context. **superset/translations/zh/LC_MESSAGES/messages.po** ``` +msgid "Fit data" +msgstr "" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
