innovark37 opened a new pull request, #41741:
URL: https://github.com/apache/superset/pull/41741

   ### SUMMARY
   Fixes #36324.
   
   Standardizes card kebab menu behavior across chart, dashboard, and saved 
query cards by introducing a shared `KebabMenuButton` component.
   
   This keeps the existing link-style button appearance while making card menus 
open on click only. The icon color is not hardcoded, so hover, active, and 
disabled states continue to inherit from the underlying Button styles.
   
   This also removes the hardcoded `colorTextLabel` icon color from dashboard 
chart header controls so the chart kebab trigger follows the same inheritance 
pattern.
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before: card kebab menus used inconsistent interaction patterns, with some 
opening on hover and click.
   <img width="1917" height="503" alt="before-welcome page" 
src="https://github.com/user-attachments/assets/da0920ae-1119-4375-b802-00afb5858131";
 />
   
   <img width="1914" height="561" alt="before-dashboard page" 
src="https://github.com/user-attachments/assets/5329ac1c-2d15-4c76-ae2b-c365c92ccfa7";
 />
   
   After: chart, dashboard, saved query, and dashboard chart kebab triggers use 
click-based interaction, while icon color is inherited from the Button state.
   <img width="1919" height="506" alt="{87E12643-21B2-4789-B8B9-A08CBB143589}" 
src="https://github.com/user-attachments/assets/e15e9d2a-be29-4a17-b4f9-bea5a516cfd0";
 />
   
   <img width="1901" height="549" alt="{63CFB0F1-0222-4CFC-84E0-CF67C8A34688}" 
src="https://github.com/user-attachments/assets/662911c9-c846-4c1d-a4c2-c09164efaf16";
 />
   
   
   
   ### TESTING INSTRUCTIONS
   1. Open the Welcome page.
   2. Hover over chart, dashboard, and saved query card kebab buttons.
   3. Verify the menu does not open on hover.
   4. Click each kebab button.
   5. Verify the menu opens on click.
   6. Open a dashboard with chart cards.
   7. Verify the chart header kebab menu still opens on click and preserves 
Button-driven hover/active styling.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #36324
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to