bito-code-review[bot] commented on code in PR #37932:
URL: https://github.com/apache/superset/pull/37932#discussion_r3519978490
##########
tests/unit_tests/commands/dataset/test_duplicate.py:
##########
@@ -84,20 +100,387 @@ def test_duplicate_dataset_access_check_passes_through()
-> None:
"superset.commands.dataset.duplicate.security_manager.raise_for_access"
) as mock_access:
with patch(
-
"superset.commands.dataset.duplicate.DatasetDAO.find_one_or_none",
- return_value=None,
+ "superset.commands.dataset.duplicate.db.session.query"
+ ) as mock_query:
+ mock_query.return_value.get.return_value = mock_database
+ with patch(
+
"superset.commands.dataset.duplicate.DatasetDAO.validate_uniqueness",
+ return_value=True,
+ ):
+ with patch(
+
"superset.commands.dataset.duplicate.DuplicateDatasetCommand.populate_owners",
+ return_value=[],
+ ):
+ command = DuplicateDatasetCommand(
+ {
+ "base_model_id": 1,
+ "table_name": "new_unique_name",
+ "is_managed_externally": False,
+ }
+ )
+ command.validate() # should not raise
+ # Confirm access check was called with the base dataset
+
mock_access.assert_called_once_with(datasource=mock_dataset)
+
+
+def test_duplicate_dataset_success():
+ """Test successful duplication of a virtual dataset."""
+ # Create a mock base model (virtual dataset)
+ mock_base_model = Mock(spec=SqlaTable)
+ mock_base_model.id = 1
+ mock_base_model.database_id = 1
+ mock_base_model.table_name = "original_dataset"
+ mock_base_model.schema = "public"
+ mock_base_model.catalog = None
+ mock_base_model.kind = "virtual"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Consolidate duplicated test setup mocks</b></div>
<div id="fix">
Code duplication detected in test file
`tests/unit_tests/commands/dataset/test_duplicate.py` across multiple locations
(135-176, 312-358, 441-481). The mock setup pattern for base_model and database
is repeated with minor variations. Consider extracting into a shared fixture to
improve maintainability.
</div>
</div>
<small><i>Code Review Run #6fb8dc</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
