etr2460 commented on issue #8389: Allow bypassing DISPLAY_MAX_ROW URL: https://github.com/apache/incubator-superset/pull/8389#issuecomment-542910434 Sorry, I probably should have thought of this before, but maybe we should have the client explicitly ask for DISPLAY_MAX_ROWS rows from the results instead of the backend automatically applying it. So instead of adding an `ignore_limit` setting, we make the default pass back the entire results set, and the client adds a `rows` query param to `/results` that requests DISPLAY_MAX_ROWS rows. I think this might be a bit cleaner, and would make the superset backend behave more like a service with multiple consumers than just assuming the client is asking by default. thoughts @villebro @betodealmeida ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
