abderbejaoui commented on PR #38490:
URL: https://github.com/apache/superset/pull/38490#issuecomment-4880368828
Thanks @rusackas! I took both suggestions:
- `metadata_cache_timeout` now only defaults to `{}` when the key is
absent/`None`, so falsy non-dict values (`0`, `""`, `[]`, `false`) are rejected
instead of being treated as empty.
- Added the non-negative check for `catalog_cache_timeout` alongside
`schema_cache_timeout` / `table_cache_timeout`.
Added tests covering both. Could you re-approve the workflows so CI can run?
Thanks again for the review 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
