gabrielwong159 commented on code in PR #41755:
URL: https://github.com/apache/superset/pull/41755#discussion_r3522513212
##########
tests/unit_tests/mcp_service/test_mcp_server.py:
##########
@@ -162,6 +162,61 @@ def
test_create_event_store_returns_none_when_redis_store_fails():
assert result is None
[email protected]
+async def test_register_health_endpoint_registers_get_health() -> None:
+ """/health is registered as an HTTP GET custom route on the MCP
instance."""
+ from superset.mcp_service.server import _register_health_endpoint
+
+ captured: dict[str, object] = {}
+
+ def custom_route(path: str, methods: list[str]): # type:
ignore[no-untyped-def]
Review Comment:
Amended the commit to introduce proper type annotations for all flagged
instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
