sadpandajoe opened a new pull request, #41758:
URL: https://github.com/apache/superset/pull/41758
### SUMMARY
The historical `/superset` URL prefix was removed from every view when
`Superset.route_base` was set to `""` — dashboards are now canonically served
at `/dashboard/<id>/`. A temporary closed-set redirect shim
(`superset/middleware/legacy_prefix_redirect.py`, removed at EOL 5.0.0) keeps
the old `/superset/dashboard/<id>/` paths working for one release cycle.
The MCP dashboard tools still hand-build `/superset/dashboard/<id>/` URLs in
their responses, so the URLs they return only resolve today by bouncing through
that temporary shim. This updates them to emit the canonical `/dashboard/<id>/`
form directly, so the returned URLs are correct on their own and keep working
after the shim is retired.
This matches `add_chart_to_existing_dashboard`, which already returns the
new `/dashboard/<id>/` form.
Files touched (all pure string changes, no behavioral logic):
- `mcp_service/dashboard/tool/duplicate_dashboard.py`
- `mcp_service/dashboard/tool/manage_native_filters.py`
- `mcp_service/dashboard/tool/remove_chart_from_dashboard.py`
- `mcp_service/dashboard/schemas.py` (field help text)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — response URL string change only.
### TESTING INSTRUCTIONS
Existing unit tests updated to assert the `/dashboard/<id>/` form:
```
pytest
tests/unit_tests/mcp_service/dashboard/tool/test_duplicate_dashboard.py \
tests/unit_tests/mcp_service/dashboard/tool/test_remove_chart_from_dashboard.py
```
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
