hainenber commented on code in PR #41767:
URL: https://github.com/apache/superset/pull/41767#discussion_r3522783296
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx:
##########
@@ -974,13 +975,15 @@ test('restores a deleted filter via the "Restore filter"
button', async () => {
const filterContainer = screen.getByTestId('filter-title-container');
const firstTab = within(filterContainer).getAllByRole('tab')[0];
- fireEvent.click(within(firstTab).getByRole('button', { name: /delete/i }));
+ fireEvent.click(
+ within(firstTab).getByRole('button', { name: REMOVE_FILTER_BUTTON_REGEX }),
+ );
expect(
await screen.findByText(/you have removed this filter/i),
).toBeInTheDocument();
const restoreButton = screen.getByTestId('restore-filter-button');
- await userEvent.click(restoreButton);
+ userEvent.click(restoreButton);
Review Comment:
Can't screenshot but VSCode emits this
```
'await' has no effect on the type of this expression.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
