hainenber commented on code in PR #41768:
URL: https://github.com/apache/superset/pull/41768#discussion_r3522842015


##########
superset-frontend/src/setup/setupApp.ts:
##########
@@ -41,7 +42,7 @@ function showApiMessage(resp: ClientErrorObject) {
   const severity = resp.severity || 'info';
   $(template)
     .addClass(`alert-${severity}`)
-    .append(resp.message || '')
+    .append(resp.message ? sanitizeHtmlIfNeeded(resp.message) : '')

Review Comment:
   But the `message` field's type is `string | undefined`. Is the typing wrong 
or is there somewhere new that produces non-string output?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to