[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #8404: filter scope selector modal

Wed, 16 Oct 2019 17:27:17 -0700 

graceguo-supercat opened a new pull request #8404: filter scope selector modal
URL: https://github.com/apache/incubator-superset/pull/8404
 
 
   ### CATEGORY
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   This is part 1 for Dashboard Scoped Filter project. This PR is for a new UI 
module and components: **filter scope selector modal**. It covers the UI/UX 
that display/select scope (tabs and charts) for any search field. Update 
dashboard redux state and persist filter scope settings to backend, will be 
covered in another PR.
   
   **Before: set filter immune in dashboard metadata**
   <img width="1140" alt="Screen_Shot_2019-10-16_at_9_49_54_AM" 
src="https://user-images.githubusercontent.com/27990562/66944436-00785e00-f002-11e9-81c1-5b16aa6ba6ae.png";>
   
   **After: single-edit mode, edit one filter field**
   
![TXAQC4vq8M](https://user-images.githubusercontent.com/27990562/66944581-4fbe8e80-f002-11e9-98ae-8e23cbbb6b6e.gif)
   
   **multi-edit mode, edit all selected filter fields:**
   
![NVVOnnHnLc](https://user-images.githubusercontent.com/27990562/66944819-c9567c80-f002-11e9-9ed7-c3980b922bed.gif)
   
   **search chart name and set scope**
   
![71qKzTDcmu](https://user-images.githubusercontent.com/27990562/66946004-e4c28700-f004-11e9-8ce3-6d80aadae7f3.gif)
   
   **Implementation**
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [X] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @etr2460 @williaster @mistercrunch @kenchendesign

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to