rusackas commented on PR #41314: URL: https://github.com/apache/superset/pull/41314#issuecomment-4883685068
@yousoph the `canOverwriteSlice` guard itself looks right... I traced it on master and `slice: null` with `can_overwrite: true` (or an admin user) really does pre-select Overwrite and send `updateSlice(undefined, ...)`. The new test is load-bearing too. Two things in the way of approving: GitHub shows conflicts - the `TablePreview.test.tsx` hunks in this branch already landed on master via #41628 (just formatted differently), so a rebase that drops those two hunks entirely should clear it. CI never ran on the current head because of the conflict, so the full suites need a green pass after the rebase. Happy to re-review once it's rebased... holler if you want a hand with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
