rusackas commented on PR #41019: URL: https://github.com/apache/superset/pull/41019#issuecomment-4884217519
@massucattoj I pushed 292853967f to your branch (thanks for leaving maintainer edits on)... the CodeAnt thread about duplicates was a fair catch. Since the infinite-scroll merge appends pages without deduping, the same query id can land in the cache twice, and the splice only removed the first copy, so a deleted query could stay visible. I swapped it for a filter over all matches (count still only drops by 1, since the server only deletes one row) and added a test seeding a duplicated cache entry. Mind taking a look at that commit? @sadpandajoe you approved before my push, so a quick re-look from you too would be great. If it looks right to both of you, this should be ready once CI's green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
