rusackas commented on PR #38495: URL: https://github.com/apache/superset/pull/38495#issuecomment-4884233628
Thanks @Harshit-Tiwary! Good news is the reason this is conflicting: both halves of it already landed on master. The `get_table_access_error_msg` gettext wrapping went in via your own #38489 (36781fbf47), and the French `bloc` placeholder fix came along with the recent catalog repair work in #41722 / #41752... so a rebase here would leave an empty diff. The remaining test file exercises Python string interpolation on hardcoded templates rather than the Superset code paths, so I don't think it adds coverage worth carrying forward on its own. Closing as superseded, but ping me if I'm misconstruing anything at all... and thanks for this and future contributions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
