rusackas commented on PR #32995: URL: https://github.com/apache/superset/pull/32995#issuecomment-4884303501
Good sleuthing @fnardin-maystreet, and sorry for the confusion... the IconButton swap came from an automated cleanup pass on my end. It traded your `disabled` prop for the existing `.action-button.disabled` class convention, but left the class unstyled everywhere, since your branch had (reasonably) deleted the DatasetList CSS it replaced. Half intentional, fully inconsistent :P I pushed two commits to your branch: one restoring the `.disabled` styles on all three list pages (keeping the className approach so the diff stays small), and a merge of current master, which should also clear the translation bot's complaint... the fuzzy counts were the branch trailing master's recent .po repairs, not your strings. If you'd rather bring back your IconButton approach instead, no objection from me, it was arguably cleaner. Otherwise I think this is close... holler if I can help get it across the finish line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
