rusackas commented on PR #41746: URL: https://github.com/apache/superset/pull/41746#issuecomment-4885045678
Thanks @durgaprasadml, the optional chaining seems like the right guard here, and it looks like these were the only unguarded `scope` reads in the dashboard utils. A small test pinning the missing-scope case would've been nice, but I won't lose too much sleep over it. LGTM, approving, and hopefully we can merge soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
