rusackas commented on PR #41617: URL: https://github.com/apache/superset/pull/41617#issuecomment-4885066809
Thanks @YinkaMetrics! Of the three open PRs for #40407, I think this is the one we should carry forward... it has a test and reuses the existing `.table-length` styling. One thing I flagged on #40656 applies here too: the message fires purely on `hasMore`, so in a readOnly control (like the DatasourceEditor in non-edit mode) it tells people to refine a search they can't run. Mind gating it on the same condition the Select already uses? The jest failures look unrelated to this change... a rebase on current `master` should tell us for sure. I'll update the branch now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
