rusackas commented on PR #37458: URL: https://github.com/apache/superset/pull/37458#issuecomment-4885076807
Thanks @costajohnt, the test restoration looks right, and the rebase helps. babel-extract is failing now though... probably the `.pot` needs regenerating since the source strings changed, but I'll update the branch here to see if it helps. The last blocker is the name itself. @yousoph wasn't sold on "Subvalue" over on the issue and floated "Summary (Sum)", and @noam-k wasn't thrilled with either. I'd love a final call before we land a user-facing string. There are three other PRs renaming this same label, so once we agree on a term we may want to close the others in favor of this one. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
