bito-code-review[bot] commented on PR #41497: URL: https://github.com/apache/superset/pull/41497#issuecomment-4886080549
<!-- Bito Reply --> The observation regarding the lack of an RBAC-denied path test for `create_theme` is accurate and aligns with the established testing convention for mutate tools in this service. Adding a test case that mocks `can_access` to `False` or uses a non-privileged user to assert that the call is denied is a recommended practice to ensure the decorator wiring and RBAC configuration are correctly applied. This will provide necessary coverage that `test_auth_rbac.py` currently lacks for this specific tool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
