bito-code-review[bot] commented on code in PR #38451:
URL: https://github.com/apache/superset/pull/38451#discussion_r3525964566
##########
superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts:
##########
@@ -419,6 +457,7 @@ test('should add a formula annotation when X-axis column
has dataset-level label
datasource: {
verboseMap: {
[timeColumnName]: timeColumnLabel,
+ sum__num: 'sum__num',
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Duplicate transformProps test assertions</b></div>
<div id="fix">
Consider extracting duplicated test setup and assertion logic into shared
utilities to reduce code duplication across test files. Similar patterns found
in MixedTimeseries/transformProps.test.ts (lines 157-171, 204-218, 460-473) and
Timeseries/transformProps.test.ts (lines 296-309, 330-341). A helper function
for formula series validation would eliminate this duplication.
</div>
</div>
<small><i>Code Review Run #a8dcd4</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
