john-bodley commented on a change in pull request #7702: [SIP-15A] Enforcing
ISO 8601 date/timestamp formats
URL:
https://github.com/apache/incubator-superset/pull/7702#discussion_r336112100
##########
File path: superset/connectors/sqla/views.py
##########
@@ -121,6 +128,24 @@ class TableColumnInlineView(CompactCRUDMixin,
SupersetModelView): # noqa
"python_date_format": _("Datetime Format"),
"type": _("Type"),
}
+ validators_columns = {
+ "python_date_format": [
+ # Restrict viable values to epoch_s, epoch_ms, or a strftime format
+ # which adhere's to the ISO 8601 format (without time zone).
+ Regexp(
Review comment:
@dpgaspar this FAB validator works but it doesn't seem to show the message.
I've successfully used validators in Superset on other PRs and I was wondering
whether there's a FAB issue displaying messages when the form field isn't on
the primary tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
