amaannawab923 commented on PR #41754: URL: https://github.com/apache/superset/pull/41754#issuecomment-4894853020
Thanks for the detailed follow ups. The empty totals guard and the calculated column test both look good, and the answer on the extra queries makes sense as a conscious trade off . LGTM !! @EnxDev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
