john-bodley opened a new pull request #8409: [ci] Deprecate flake8 URL: https://github.com/apache/incubator-superset/pull/8409 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This PR deprecates `flake8` in favor of using `isort`, `mypy`, and `pylint`. The reasons being are: 1. We've noticed in other reports that `flake8-mypy` has missed some issues that `mypy` discovers (fixed in this PR) and ignores some of the `mypy` settings. 2. We were using `flake8` mostly for checking import order and typing now that we're using `black`. Note that `isort` both checks and formats. Note we were using `flake8` for some other checks but simply ignoring these via `# noqa` which lacked specificity, i.e., reading the code it's not apparent what we're ignoring. Ideally we should be upping our `pylint` game as these checks would be caught by `pylint`. Currently many files have `pylint` warnings ignored and we have disabled a number of checks in the `.pylintrc` file per [here](https://github.com/apache/incubator-superset/blob/master/.pylintrc#L84). In the future we enforce `pylint` for all errors and warning and enable most (if not all) checks. There are a few cases where I used `# type: ignore` as I ended up going down a rabbit hole when trying to resolve types. I think in the future we should try to re-enable these checks. ### TEST PLAN CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @betodealmeida @etr2460 @michellethomas @mistercrunch @villebro
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
